Fix type unification for type parameters - #1479
Open
l46kok wants to merge 3 commits into
Open
Conversation
| // or conform to an existing binding in 'm'. Returns false on structural/kind mismatches | ||
| // (e.g., int vs list(T)), occurs-check cycles, or conflicting type param bindings. | ||
| if hasTypeParam(fromType) || hasTypeParam(toType) { | ||
| return internalIsAssignable(m, fromType, toType) |
Collaborator
There was a problem hiding this comment.
I think there might be some issue with the occurs check with inputs like:
type(map(string, T)), type(T)
Collaborator
Author
There was a problem hiding this comment.
We should be ok, the type substitution check propagates for map parameters. I've added some tests around this just to be sure.
l46kok
marked this pull request as ready for review
September 10, 2026 22:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port of
cel-expr/cel-java#1211
cel-expr/cel-cpp#2260